google_apis/drive/test_util.cc - Issue 1394993004: Make ValueDeserializer::Deserialize return scoped_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: google_apis/drive/test_util.cc

Issue 1394993004: Make ValueDeserializer::Deserialize return scoped_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix and add todo about not failed trybot Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: google_apis/drive/test_util.cc

diff --git a/google_apis/drive/test_util.cc b/google_apis/drive/test_util.cc

index e77aedfdeb015d5b455cd1f13779c1df40ef6e1d..e5885195a60ff6679b8ce5f3ec37a7dd4f03cb81 100644

--- a/google_apis/drive/test_util.cc

+++ b/google_apis/drive/test_util.cc

@@ -82,7 +82,7 @@ scoped_ptr<base::Value> LoadJSONFile(const std::string& relative_path) {

std::string error;

JSONFileValueDeserializer deserializer(path);

- scoped_ptr<base::Value> value(deserializer.Deserialize(NULL, &error));

+ scoped_ptr<base::Value> value = deserializer.Deserialize(NULL, &error);

LOG_IF(WARNING, !value.get()) << "Failed to parse " << path.value()

<< ": " << error;

return value.Pass();

« no previous file with comments | « extensions/utility/unpacker.cc ('k') | remoting/host/pairing_registry_delegate_linux.cc » ('j') | no next file with comments »