extensions/common/file_util_unittest.cc - Issue 1394993004: Make ValueDeserializer::Deserialize return scoped_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/file_util_unittest.cc

Issue 1394993004: Make ValueDeserializer::Deserialize return scoped_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix and add todo about not failed trybot Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/common/file_util_unittest.cc

diff --git a/extensions/common/file_util_unittest.cc b/extensions/common/file_util_unittest.cc

index df82b8293ee5ac224137f569b7131a13855d0082..0814334bfacc283895372b39d95bdc636eeb7d2e 100644

--- a/extensions/common/file_util_unittest.cc

+++ b/extensions/common/file_util_unittest.cc

@@ -44,7 +44,7 @@ scoped_refptr<Extension> LoadExtensionManifest(

int extra_flags,

std::string* error) {

JSONStringValueDeserializer deserializer(manifest_value);

- scoped_ptr<base::Value> result(deserializer.Deserialize(NULL, error));

+ scoped_ptr<base::Value> result = deserializer.Deserialize(NULL, error);

if (!result.get())

return NULL;

CHECK_EQ(base::Value::TYPE_DICTIONARY, result->GetType());

« no previous file with comments | « extensions/common/extension_l10n_util.cc ('k') | extensions/common/manifest_test.cc » ('j') | no next file with comments »