Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Unified Diff: chromecast/base/serializers.cc

Issue 1394993004: Make ValueDeserializer::Deserialize return scoped_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix and add todo about not failed trybot Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/utility/importer/firefox_importer.cc ('k') | chromeos/app_mode/kiosk_oem_manifest_parser.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromecast/base/serializers.cc
diff --git a/chromecast/base/serializers.cc b/chromecast/base/serializers.cc
index 34bc9fd3cdea408e7543179786411482bcf3dde9..2e6135bb17fdc4b7cce15227d38c3d99e3ac5874 100644
--- a/chromecast/base/serializers.cc
+++ b/chromecast/base/serializers.cc
@@ -15,8 +15,8 @@ scoped_ptr<base::Value> DeserializeFromJson(const std::string& text) {
int error_code = -1;
std::string error_msg;
- scoped_ptr<base::Value> value(
- deserializer.Deserialize(&error_code, &error_msg));
+ scoped_ptr<base::Value> value =
+ deserializer.Deserialize(&error_code, &error_msg);
DLOG_IF(ERROR, !value) << "JSON error " << error_code << ":" << error_msg;
// Value will hold the nullptr in case of an error.
@@ -36,8 +36,8 @@ scoped_ptr<base::Value> DeserializeJsonFromFile(const base::FilePath& path) {
int error_code = -1;
std::string error_msg;
- scoped_ptr<base::Value> value(
- deserializer.Deserialize(&error_code, &error_msg));
+ scoped_ptr<base::Value> value =
+ deserializer.Deserialize(&error_code, &error_msg);
DLOG_IF(ERROR, !value) << "JSON error " << error_code << ":" << error_msg;
// Value will hold the nullptr in case of an error.
« no previous file with comments | « chrome/utility/importer/firefox_importer.cc ('k') | chromeos/app_mode/kiosk_oem_manifest_parser.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698