chrome/browser/ui/cocoa/extensions/extension_install_prompt_test_utils.mm - Issue 1394993004: Make ValueDeserializer::Deserialize return scoped_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/extensions/extension_install_prompt_test_utils.mm

Issue 1394993004: Make ValueDeserializer::Deserialize return scoped_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix and add todo about not failed trybot Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/cocoa/extensions/extension_install_prompt_test_utils.mm

diff --git a/chrome/browser/ui/cocoa/extensions/extension_install_prompt_test_utils.mm b/chrome/browser/ui/cocoa/extensions/extension_install_prompt_test_utils.mm

index bbfc886a3ec35d5d52cb9eab521ff170ccf3d4e5..b2e2a700791a3b8d416f0cd9d58afdd87dc32d3f 100644

--- a/chrome/browser/ui/cocoa/extensions/extension_install_prompt_test_utils.mm

+++ b/chrome/browser/ui/cocoa/extensions/extension_install_prompt_test_utils.mm

@@ -36,8 +36,8 @@ scoped_refptr<extensions::Extension> LoadInstallPromptExtension(

std::string error;

JSONFileValueDeserializer deserializer(path);

- scoped_ptr<base::DictionaryValue> value(static_cast<base::DictionaryValue*>(

- deserializer.Deserialize(NULL, &error)));

+ scoped_ptr<base::DictionaryValue> value =

+ base::DictionaryValue::From(deserializer.Deserialize(NULL, &error));

if (!value.get()) {

LOG(ERROR) << error;

return extension;

« no previous file with comments | « chrome/browser/ui/app_list/start_page_service.cc ('k') | chrome/browser/ui/webui/nacl_ui.cc » ('j') | no next file with comments »