chrome/browser/chromeos/app_mode/kiosk_external_updater.cc - Issue 1394993004: Make ValueDeserializer::Deserialize return scoped_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/app_mode/kiosk_external_updater.cc

Issue 1394993004: Make ValueDeserializer::Deserialize return scoped_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix and add todo about not failed trybot Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/android/contextualsearch/contextual_search_delegate.cc ('k') | chrome/browser/chromeos/app_mode/startup_app_launcher.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/app_mode/kiosk_external_updater.cc

diff --git a/chrome/browser/chromeos/app_mode/kiosk_external_updater.cc b/chrome/browser/chromeos/app_mode/kiosk_external_updater.cc

index a875b8e3377de788586e874d8c961510e243d188..a753217d4a39e38e4d3dc404ce242520657b0e3d 100644

--- a/chrome/browser/chromeos/app_mode/kiosk_external_updater.cc

+++ b/chrome/browser/chromeos/app_mode/kiosk_external_updater.cc

@@ -44,7 +44,9 @@ void ParseExternalUpdateManifest(

JSONFileValueDeserializer deserializer(manifest);

std::string error_msg;

- base::Value* extensions = deserializer.Deserialize(NULL, &error_msg);

+ base::Value* extensions =

+ deserializer.Deserialize(NULL, &error_msg).release();

+ // TODO(Olli Raula) possible memory leak http://crbug.com/543015

if (!extensions) {

*error_code = KioskExternalUpdater::ERROR_INVALID_MANIFEST;

return;