extensions/common/manifest_test.cc - Issue 1394993004: Make ValueDeserializer::Deserialize return scoped_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/manifest_test.cc

Issue 1394993004: Make ValueDeserializer::Deserialize return scoped_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix and add ::From Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« extensions/common/extension_l10n_util.cc ('K') | « extensions/common/file_util_unittest.cc ('k') | extensions/utility/unpacker.cc » ('j') | ui/app_list/search/dictionary_data_store.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/common/manifest_test.cc

diff --git a/extensions/common/manifest_test.cc b/extensions/common/manifest_test.cc

index 048e1838a2ec2f5e73f2b137ca5f11a92f3b82af..37034b5927e2c313389bc3889ad80d35a0d61e00 100644

--- a/extensions/common/manifest_test.cc

+++ b/extensions/common/manifest_test.cc

@@ -29,7 +29,7 @@ base::DictionaryValue* LoadManifestFile(const base::FilePath& manifest_path,

JSONFileValueDeserializer deserializer(manifest_path);

base::DictionaryValue* manifest = static_cast<base::DictionaryValue*>(

- deserializer.Deserialize(NULL, error));

+ deserializer.Deserialize(NULL, error).release());

// Most unit tests don't need localization, and they'll fail if we try to

// localize them, since their manifests don't have a default_locale key.

« extensions/common/extension_l10n_util.cc ('K') | « extensions/common/file_util_unittest.cc ('k') | extensions/utility/unpacker.cc » ('j') | ui/app_list/search/dictionary_data_store.cc » ('J')