Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2428)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: extensions/browser/api/printer_provider/printer_provider_api.cc

Issue 1394993004: Make ValueDeserializer::Deserialize return scoped_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix and add ::From Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chromeos/tools/onc_validator/onc_validator.cc ('K') | « components/update_client/component_unpacker.cc ('k') | extensions/browser/extension_icon_image_unittest.cc » ('j') | extensions/browser/extension_icon_image_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/api/printer_provider/printer_provider_api.cc
diff --git a/extensions/browser/api/printer_provider/printer_provider_api.cc b/extensions/browser/api/printer_provider/printer_provider_api.cc
index 8b02814d1c0004a88af041bc5839eb46c8979d86..b5d16a8ec66c88033cce1e2d1667dbca9b47ba61 100644
--- a/extensions/browser/api/printer_provider/printer_provider_api.cc
+++ b/extensions/browser/api/printer_provider/printer_provider_api.cc
@@ -594,7 +594,7 @@ void PrinterProviderAPIImpl::DispatchPrintRequested(
print_job.printer_id = internal_printer_id;
JSONStringValueDeserializer deserializer(job.ticket_json);
- scoped_ptr<base::Value> ticket_value(deserializer.Deserialize(NULL, NULL));
+ scoped_ptr<base::Value> ticket_value = deserializer.Deserialize(NULL, NULL);
if (!ticket_value ||
!api::printer_provider::PrintJob::Ticket::Populate(*ticket_value,
&print_job.ticket)) {
« chromeos/tools/onc_validator/onc_validator.cc ('K') | « components/update_client/component_unpacker.cc ('k') | extensions/browser/extension_icon_image_unittest.cc » ('j') | extensions/browser/extension_icon_image_unittest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698