Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chromeos/app_mode/kiosk_oem_manifest_parser.cc

Issue 1394993004: Make ValueDeserializer::Deserialize return scoped_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix and add ::From Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/extensions/extension_action_icon_factory_unittest.cc ('K') | « chromecast/base/serializers.cc ('k') | chromeos/dbus/fake_easy_unlock_client.cc » ('j') | chromeos/network/onc/onc_test_utils.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromeos/app_mode/kiosk_oem_manifest_parser.cc
diff --git a/chromeos/app_mode/kiosk_oem_manifest_parser.cc b/chromeos/app_mode/kiosk_oem_manifest_parser.cc
index f13d1a8fd9cdd21e946ea8ac93ea6c52d7f05521..16c072ab9c7b1e1c35f3145bd7af27eefb97f940 100644
--- a/chromeos/app_mode/kiosk_oem_manifest_parser.cc
+++ b/chromeos/app_mode/kiosk_oem_manifest_parser.cc
@@ -32,8 +32,8 @@ bool KioskOemManifestParser::Load(
std::string error_msg;
scoped_ptr<JSONFileValueDeserializer> deserializer(
new JSONFileValueDeserializer(kiosk_oem_file));
- scoped_ptr<base::Value> value(
- deserializer->Deserialize(&error_code, &error_msg));
+ scoped_ptr<base::Value> value =
+ deserializer->Deserialize(&error_code, &error_msg);
base::DictionaryValue* dict = NULL;
if (error_code != JSONFileValueDeserializer::JSON_NO_ERROR ||
!value.get() ||
« chrome/browser/extensions/extension_action_icon_factory_unittest.cc ('K') | « chromecast/base/serializers.cc ('k') | chromeos/dbus/fake_easy_unlock_client.cc » ('j') | chromeos/network/onc/onc_test_utils.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698