Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1533)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/chromeos/app_mode/kiosk_external_updater.cc

Issue 1394993004: Make ValueDeserializer::Deserialize return scoped_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix and add ::From Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/android/contextualsearch/contextual_search_delegate.cc ('k') | chrome/browser/chromeos/app_mode/startup_app_launcher.cc » ('j') | chrome/browser/component_updater/recovery_component_installer.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/app_mode/kiosk_external_updater.cc
diff --git a/chrome/browser/chromeos/app_mode/kiosk_external_updater.cc b/chrome/browser/chromeos/app_mode/kiosk_external_updater.cc
index a875b8e3377de788586e874d8c961510e243d188..708d13ab5cea77d9bbd74f4d28a91e08909f26b9 100644
--- a/chrome/browser/chromeos/app_mode/kiosk_external_updater.cc
+++ b/chrome/browser/chromeos/app_mode/kiosk_external_updater.cc
@@ -44,7 +44,9 @@ void ParseExternalUpdateManifest(
JSONFileValueDeserializer deserializer(manifest);
std::string error_msg;
- base::Value* extensions = deserializer.Deserialize(NULL, &error_msg);
+ base::Value* extensions =
+ deserializer.Deserialize(NULL, &error_msg).release();
+ // TODO(Olli Raula) possible memoryleak http://crbug.com/543015
Lei Zhang 2015/10/14 16:46:14 memory leak is two words.
if (!extensions) {
*error_code = KioskExternalUpdater::ERROR_INVALID_MANIFEST;
return;
« no previous file with comments | « chrome/browser/android/contextualsearch/contextual_search_delegate.cc ('k') | chrome/browser/chromeos/app_mode/startup_app_launcher.cc » ('j') | chrome/browser/component_updater/recovery_component_installer.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698