Make ValueDeserializer::Deserialize return scoped_ptr

chromeos/tools/onc_validator/onc_validator.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <cstdio>
 #include <iostream>
 
 #include "base/basictypes.h"
 #include "base/command_line.h"
 #include "base/files/file_path.h"
@@ skipping 72 matching lines @@
 }
 
 scoped_ptr<base::DictionaryValue> ReadDictionary(const std::string& filename) {
   base::FilePath path(filename);
   JSONFileValueDeserializer deserializer(path);
   deserializer.set_allow_trailing_comma(true);
 
   base::DictionaryValue* dict = NULL;
 
   std::string json_error;
-  base::Value* value = deserializer.Deserialize(NULL, &json_error);
-  if (!value) {
+  base::Value* value = deserializer.Deserialize(NULL, &json_error).release();
+  TODO(Olli Raula)

[Lei Zhang, 2015/10/15 17:36:11]

I think you forgot some slashes here. And again, "memory leak"

I'm a little worried about this file since the try bots passed.

+  possible memoryleak http :  // crbug.com/543015
+                              if (!value) {
     LOG(ERROR) << "Couldn't json-deserialize file '" << filename
                << "': " << json_error;
     return make_scoped_ptr(dict);
   }
 
   if (!value->GetAsDictionary(&dict)) {
     LOG(ERROR) << "File '" << filename
                << "' does not contain a dictionary as expected, but type "
                << value->GetType();
   }
@@ skipping 50 matching lines @@
     case chromeos::onc::Validator::VALID:
       return kStatusValid;
     case chromeos::onc::Validator::VALID_WITH_WARNINGS:
       return kStatusWarnings;
     case chromeos::onc::Validator::INVALID:
       return kStatusInvalid;
     default:
       CHECK(false);
   }
 }