Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Side by Side Diff: src/runtime/runtime-scopes.cc

Issue 1394983005: Restructure Object::SetProperty and related functions. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Rebase. Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« src/objects.cc ('K') | « src/runtime/runtime-object.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/runtime/runtime-utils.h" 5 #include "src/runtime/runtime-utils.h"
6 6
7 #include "src/accessors.h" 7 #include "src/accessors.h"
8 #include "src/arguments.h" 8 #include "src/arguments.h"
9 #include "src/frames-inl.h" 9 #include "src/frames-inl.h"
10 #include "src/isolate-inl.h" 10 #include "src/isolate-inl.h"
(...skipping 846 matching lines...) Expand 10 before | Expand all | Expand 10 after
857 break; 857 break;
858 } 858 }
859 case TEMPORARY: 859 case TEMPORARY:
860 case DYNAMIC: 860 case DYNAMIC:
861 case DYNAMIC_GLOBAL: 861 case DYNAMIC_GLOBAL:
862 case DYNAMIC_LOCAL: 862 case DYNAMIC_LOCAL:
863 UNREACHABLE(); 863 UNREACHABLE();
864 } 864 }
865 } 865 }
866 866
867 if (JSObject::PreventExtensions(module, THROW_ON_ERROR).IsNothing()) 867 if (JSObject::PreventExtensions(module, Object::THROW_ON_ERROR).IsNothing())
868 DCHECK(false); 868 DCHECK(false);
869 } 869 }
870 870
871 DCHECK(!isolate->has_pending_exception()); 871 DCHECK(!isolate->has_pending_exception());
872 return isolate->heap()->undefined_value(); 872 return isolate->heap()->undefined_value();
873 } 873 }
874 874
875 875
876 RUNTIME_FUNCTION(Runtime_DeleteLookupSlot) { 876 RUNTIME_FUNCTION(Runtime_DeleteLookupSlot) {
877 HandleScope scope(isolate); 877 HandleScope scope(isolate);
(...skipping 289 matching lines...) Expand 10 before | Expand all | Expand 10 after
1167 1167
1168 // Lookup in the initial Object.prototype object. 1168 // Lookup in the initial Object.prototype object.
1169 Handle<Object> result; 1169 Handle<Object> result;
1170 ASSIGN_RETURN_FAILURE_ON_EXCEPTION( 1170 ASSIGN_RETURN_FAILURE_ON_EXCEPTION(
1171 isolate, result, 1171 isolate, result,
1172 Object::GetProperty(isolate->initial_object_prototype(), key)); 1172 Object::GetProperty(isolate->initial_object_prototype(), key));
1173 return *result; 1173 return *result;
1174 } 1174 }
1175 } // namespace internal 1175 } // namespace internal
1176 } // namespace v8 1176 } // namespace v8
OLDNEW
« src/objects.cc ('K') | « src/runtime/runtime-object.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698