Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Side by Side Diff: src/api-natives.cc

Issue 1394983005: Restructure Object::SetProperty and related functions. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Rebase. Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/api.cc ('k') | src/bootstrapper.cc » ('j') | src/objects.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 the V8 project authors. All rights reserved. 1 // Copyright 2015 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/api-natives.h" 5 #include "src/api-natives.h"
6 6
7 #include "src/api.h" 7 #include "src/api.h"
8 #include "src/isolate-inl.h" 8 #include "src/isolate-inl.h"
9 #include "src/lookup.h" 9 #include "src/lookup.h"
10 #include "src/messages.h" 10 #include "src/messages.h"
(...skipping 282 matching lines...) Expand 10 before | Expand all | Expand 10 after
293 Handle<FunctionTemplateInfo>::cast(parent)), 293 Handle<FunctionTemplateInfo>::cast(parent)),
294 JSFunction); 294 JSFunction);
295 // TODO(dcarney): decide what to do here. 295 // TODO(dcarney): decide what to do here.
296 Handle<Object> parent_prototype; 296 Handle<Object> parent_prototype;
297 ASSIGN_RETURN_ON_EXCEPTION( 297 ASSIGN_RETURN_ON_EXCEPTION(
298 isolate, parent_prototype, 298 isolate, parent_prototype,
299 JSObject::GetProperty(parent_instance, 299 JSObject::GetProperty(parent_instance,
300 isolate->factory()->prototype_string()), 300 isolate->factory()->prototype_string()),
301 JSFunction); 301 JSFunction);
302 MAYBE_RETURN(JSObject::SetPrototype(prototype, parent_prototype, false, 302 MAYBE_RETURN(JSObject::SetPrototype(prototype, parent_prototype, false,
303 THROW_ON_ERROR), 303 Object::THROW_ON_ERROR),
304 MaybeHandle<JSFunction>()); 304 MaybeHandle<JSFunction>());
305 } 305 }
306 } 306 }
307 auto function = ApiNatives::CreateApiFunction( 307 auto function = ApiNatives::CreateApiFunction(
308 isolate, data, prototype, ApiNatives::JavaScriptObjectType); 308 isolate, data, prototype, ApiNatives::JavaScriptObjectType);
309 if (!name.is_null() && name->IsString()) { 309 if (!name.is_null() && name->IsString()) {
310 function->shared()->set_name(*name); 310 function->shared()->set_name(*name);
311 } 311 }
312 if (!data->do_not_cache()) { 312 if (!data->do_not_cache()) {
313 // Cache the function. 313 // Cache the function.
(...skipping 316 matching lines...) Expand 10 before | Expand all | Expand 10 after
630 Handle<AccessorInfo> accessor(AccessorInfo::cast(array->get(i))); 630 Handle<AccessorInfo> accessor(AccessorInfo::cast(array->get(i)));
631 JSObject::SetAccessor(result, accessor).Assert(); 631 JSObject::SetAccessor(result, accessor).Assert();
632 } 632 }
633 633
634 DCHECK(result->shared()->IsApiFunction()); 634 DCHECK(result->shared()->IsApiFunction());
635 return result; 635 return result;
636 } 636 }
637 637
638 } // namespace internal 638 } // namespace internal
639 } // namespace v8 639 } // namespace v8
OLDNEW
« no previous file with comments | « src/api.cc ('k') | src/bootstrapper.cc » ('j') | src/objects.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698