Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 139493002: Make it possible to compile d8 for the host toolset as well (Closed)

Created:
6 years, 11 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 11 months ago
Reviewers:
Michael Achenbach
CC:
v8-dev
Visibility:
Public.

Description

Make it possible to compile d8 for the host toolset as well 2nd attempt. Use a different output path for the host d8. BUG=v8:1775 R=machenbach@chromium.org LOG=n Committed: https://code.google.com/p/v8/source/detail?r=18621

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M src/d8.gyp View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jochen (gone - plz use gerrit)
6 years, 11 months ago (2014-01-15 15:14:38 UTC) #1
Michael Achenbach
On 2014/01/15 15:14:38, jochen wrote: lgtm
6 years, 11 months ago (2014-01-15 15:34:06 UTC) #2
jochen (gone - plz use gerrit)
Committed patchset #1 manually as r18621 (presubmit successful).
6 years, 11 months ago (2014-01-15 15:35:16 UTC) #3
jochen (gone - plz use gerrit)
6 years, 11 months ago (2014-01-15 15:46:57 UTC) #4
Message was sent while issue was closed.
A revert of this CL has been created in
https://codereview.chromium.org/139523003/ by jochen@chromium.org.

The reason for reverting is: still doesn't work on arm.

Powered by Google App Engine
This is Rietveld 408576698