Need to call RegisterJni for testing.

Need to call RegisterJni for testing.

BUG=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194530

[Raymond Toy (Google), 2013-04-16 22:39:26]

cjhopman, shashishekhar:  Please review the gyp change.  openmax_dl will only be
used for Android ARM, not x86.

dalecurtis: Please review media_android.cc.  Need to call RegisterJni when
initializing for testing.

[shashi, 2013-04-16 22:41:00]

lgtm

https://codereview.chromium.org/13949012/diff/8001/build/common.gypi
File build/common.gypi (right):

https://codereview.chromium.org/13949012/diff/8001/build/common.gypi#newcode649
build/common.gypi:649: 'use_openmax_dl_fft%': 0,
nit: not aligned, delete extra space.

[Raymond Toy (Google), 2013-04-16 22:41:46]

+wjia

[wjia(left Chromium), 2013-04-16 22:50:09]

lgtm when shashi@'s comment is addressed.

[DaleCurtis, 2013-04-16 22:54:46]

lgtm

https://codereview.chromium.org/13949012/diff/8001/build/common.gypi
File build/common.gypi (right):

https://codereview.chromium.org/13949012/diff/8001/build/common.gypi#newcode687
build/common.gypi:687: # Whether Android uses OpenMAX DL FFT.  Default is no.
Default is yes now?

[Raymond Toy (Google), 2013-04-16 23:01:05]

https://codereview.chromium.org/13949012/diff/8001/build/common.gypi
File build/common.gypi (right):

https://codereview.chromium.org/13949012/diff/8001/build/common.gypi#newcode687
build/common.gypi:687: # Whether Android uses OpenMAX DL FFT.  Default is no.
On 2013/04/16 22:54:46, DaleCurtis wrote:
> Default is yes now?

This should be deleted in favor of lines 644-650.

[Raymond Toy (Google), 2013-04-17 04:01:15]

Committed patchset #2 manually as r194530 (presubmit successful).

[Torne, 2013-04-17 12:26:25]

This commit message doesn't mention that this actually enables the WebAudio API
on Android and introduces a new dependency on openmax_dl on that platform which
wasn't previously required. Please make sure that commits that enable features
or add extra libraries mention what they are doing in their messages so that
it's obvious when reading commit logs.

[Raymond Toy (Google), 2013-04-17 15:58:17]

On 2013/04/17 12:26:25, Torne wrote:
> This commit message doesn't mention that this actually enables the WebAudio
API
> on Android and introduces a new dependency on openmax_dl on that platform
which
> wasn't previously required. Please make sure that commits that enable features
> or add extra libraries mention what they are doing in their messages so that
> it's obvious when reading commit logs.

The actual feature implementation and extra libraries were added in earlier CLs.
 Nevertheless, I apologize and will strive to have more explicit log messages.

[Torne, 2013-04-17 16:00:48]

On 2013/04/17 15:58:17, rtoy wrote:
> On 2013/04/17 12:26:25, Torne wrote:
> > This commit message doesn't mention that this actually enables the WebAudio
> API
> > on Android and introduces a new dependency on openmax_dl on that platform
> which
> > wasn't previously required. Please make sure that commits that enable
features
> > or add extra libraries mention what they are doing in their messages so that
> > it's obvious when reading commit logs.
> 
> The actual feature implementation and extra libraries were added in earlier
CLs.
>  Nevertheless, I apologize and will strive to have more explicit log messages.

Right, but they were *disabled* and therefore irrelevant to most other
developers until this CL; this is the most critical point to highlight the
addition.