Issue 13949009: Prepare gyp_chromium for WebCore move

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13949009: Prepare gyp_chromium for WebCore move (Closed)

Created:
7 years, 8 months ago by abarth-chromium

Modified:
7 years, 8 months ago

Reviewers:
Dirk Pranke, Nico

CC:
chromium-reviews, dpranke, (unused - use chromium)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Prepare gyp_chromium for WebCore move We're about to move Source/WebCore to Source/core. This file has a dependency on the name "WebCore" and therefore needs to be updated before the move. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194448

Patch Set 1 #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	build/gyp_chromium	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

abarth-chromium

Committed patchset #1 manually as r194448 (presubmit successful).

7 years, 8 months ago (2013-04-16 21:05:29 UTC) #3

Nico

lgtm too If this wasn't landed yet, I would've asked you to add a FIXME ...

7 years, 8 months ago (2013-04-16 23:35:22 UTC) #4

abarth-chromium

7 years, 8 months ago (2013-04-16 23:39:49 UTC) #5

Message was sent while issue was closed.

On 2013/04/16 23:35:22, Nico wrote:
> lgtm too
> 
> If this wasn't landed yet, I would've asked you to add a FIXME to remove the
old
> path once the move is completed. Since it's landed: Had you added a BUG line
> with a tracking bug, I would've left a comment there. Since there's no BUG
line
> either, I'm leaving this comment here :-P

Thanks for the prodding.  :)

I'll remove the old entry when the move is complete (hopefully tonight).

I filed https://code.google.com/p/chromium/issues/detail?id=232165 to track this
work.

Expand Messages | Collapse Messages