Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 13949005: Add cpplint for webkit/compositor_bindings (Closed)

Created:
7 years, 8 months ago by enne (OOO)
Modified:
7 years, 8 months ago
Reviewers:
danakj
CC:
chromium-reviews, cc-bugs_chromium.org, darin-cc_chromium.org, jamesr
Visibility:
Public.

Description

Add cpplint for webkit/compositor_bindings Clean up the only presubmit error in the compositor bindings and turn on cpplint warnings to prevent any future regressions. Also, clean up cc's presubmit to match now that depot_tools has cpplint in its input_api. R=danakj@chromium.org BUG=none

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -13 lines) Patch
M cc/PRESUBMIT.py View 1 chunk +3 lines, -12 lines 0 comments Download
A webkit/compositor_bindings/PRESUBMIT.py View 1 chunk +33 lines, -0 lines 0 comments Download
M webkit/compositor_bindings/web_external_texture_layer_impl.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
enne (OOO)
7 years, 8 months ago (2013-04-16 19:18:25 UTC) #1
danakj
LGTM!
7 years, 8 months ago (2013-04-16 19:22:57 UTC) #2
enne (OOO)
7 years, 8 months ago (2013-04-17 16:12:09 UTC) #3
Message was sent while issue was closed.
Committed as r194598.

Powered by Google App Engine
This is Rietveld 408576698