change isRect to return true for 3-sided rectangular paths

change isRect to return true for 3-sided rectangular paths

BUG=skia:

Committed: http://code.google.com/p/skia/source/detail?r=13092

[caryclark, 2014-01-15 15:07:15]

https://codereview.chromium.org/139483002/diff/1/tests/PathTest.cpp
File tests/PathTest.cpp (right):

https://codereview.chromium.org/139483002/diff/1/tests/PathTest.cpp#newcode1528
tests/PathTest.cpp:1528: testIndex = 26;
Debugging line left in by accident?

[reed1, 2014-01-15 15:51:02]

https://codereview.chromium.org/139483002/diff/1/tests/PathTest.cpp
File tests/PathTest.cpp (right):

https://codereview.chromium.org/139483002/diff/1/tests/PathTest.cpp#newcode1528
tests/PathTest.cpp:1528: testIndex = 26;
On 2014/01/15 15:07:15, caryclark wrote:
> Debugging line left in by accident?

Indeed. Fixed.

[caryclark, 2014-01-15 15:54:57]

lgtm

[commit-bot: I haz the power, 2014-01-15 17:06:52]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/reed@google.com/139483002/140001

[commit-bot: I haz the power, 2014-01-15 18:00:59]

Change committed as 13092

[yunchao, 2014-01-23 02:53:17]

On 2014/01/15 18:00:59, I haz the power (commit-bot) wrote:

I don't think this patch is correct. Because stroke paths are not considered. 
For thess patch: 
(1) 3-sided rect paths
(2) 4 sided but the last edge is not long enough to reach the start
They can be treated as a rect only if it is filled. 

So I think my patch(https://codereview.chromium.org/54523002/) to return 3
states is reasonable: SkNone_PathAsRect, SkFill_PathAsRect, SkStroke_PathAsRect.
for (1) and (2), we should return the caller SkFill_PathAsRect.

And isclosed is a redundant info. I should not take effect. For example, this
case that in BUG=skia:2040
SkPath path;
path.moveTo(0,0);
path.lineTo(8,0);
path.lineTo(8,8);
path.lineTo(0,8);

path.lineTo(0,0);

We should not tell the caller that this path is closed if there is no
path.close(). Because for stroke path, this path is not closed at all. It is a
contour with ends. 
Also, we should return SkFill_PathAsRect too. 

In all, I think add an API SkPath::asRect to return 3 states is better than
SkPath::isRect who return just true or false. The latter can't handle non-closed
paths. We should return SkFill_PathAsRect for this kind paths, not just return
true.