Issue 13948004: Locate javac using the JAVA_HOME env variable when building the analyzer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13948004: Locate javac using the JAVA_HOME env variable when building the analyzer. (Closed)

Created:
7 years, 8 months ago by devoncarew

Modified:
7 years, 8 months ago

Reviewers:
ricow1, ahe

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Locate javac using the JAVA_HOME env variable when building the analyzer. Committed: https://code.google.com/p/dart/source/detail?r=21171

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -4 lines)			Patch
	M	editor/tools/compile_analyzer.py	View	1	4 chunks	+26 lines, -4 lines	0 comments	Download

Total messages: 5 (0 generated)

ahe

I'm surprised that javac and jar aren't exe files, but otherwise LGTM!

7 years, 8 months ago (2013-04-09 20:45:05 UTC) #2

devoncarew

On 2013/04/09 20:45:05, ahe wrote: > I'm surprised that javac and jar aren't exe files, ...

7 years, 8 months ago (2013-04-09 21:05:37 UTC) #3

devoncarew

7 years, 8 months ago (2013-04-09 21:14:37 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r21171 (presubmit successful).