Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Issue 1394793004: Move WorldImpact to universe/world_impact.dart (Closed)

Created:
5 years, 2 months ago by Johnni Winther
Modified:
5 years, 2 months ago
Reviewers:
sigurdm
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -75 lines) Patch
M pkg/compiler/lib/src/common/backend_api.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/common/codegen.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/common/resolution.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/common/work.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/compiler.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/dart_backend/dart_backend.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/deferred_load.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/enqueue.dart View 2 chunks +2 lines, -55 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/js_backend.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/resolution/resolution.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/serialization/task.dart View 1 chunk +2 lines, -1 line 0 comments Download
A pkg/compiler/lib/src/universe/world_impact.dart View 1 chunk +70 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/exit_code_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tests/compiler/dart2js/serialization_analysis_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Johnni Winther
Main changes in enqueue.dart and universe/world_impact.dart
5 years, 2 months ago (2015-10-14 08:36:32 UTC) #2
sigurdm
LGTM
5 years, 2 months ago (2015-10-14 09:04:40 UTC) #3
Johnni Winther
5 years, 2 months ago (2015-10-14 13:22:52 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5a956826a5a8883eb3a7f54b914e44b82ce4ee95 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698