Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1394793003: Throttle media decoding after excessive Android media server crashes (Closed)

Created:
5 years, 2 months ago by qinmin
Modified:
5 years, 2 months ago
Reviewers:
CC:
chromium-reviews, asanka, posciak+watch_chromium.org, benjhayden+dwatch_chromium.org, avayvod+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, mlamouri+watch-media_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2526
Target Ref:
refs/pending/branch-heads/2526
Project:
chromium
Visibility:
Public.

Description

Throttle media decoding after excessive Android media server crashes This change adds a watch dog player to listen to android MediaServer crashes. When the number of crashes reaches a certain threshold, all media decoding using Android MediaPlayer/MediaCodec will be throttled. This will throttle both media and webaudio implementation. BUG=532745 TBR=tedchoc, jochen, cpu, Review URL: https://codereview.chromium.org/1372203002 Cr-Commit-Position: refs/heads/master@{#352740} (cherry picked from commit b2341d25796fe6f94fb9a2d00104f2f88ca67a7c) Committed: https://chromium.googlesource.com/chromium/src/+/955ff982a4146c7871bafb289c6be02c57ed059c

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+712 lines, -175 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +13 lines, -0 lines 0 comments Download
A chrome/browser/android/media/media_throttle_infobar_delegate.h View 1 chunk +44 lines, -0 lines 0 comments Download
A chrome/browser/android/media/media_throttle_infobar_delegate.cc View 1 chunk +74 lines, -0 lines 0 comments Download
M chrome/browser/android/tab_web_contents_delegate_android.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/android/tab_web_contents_delegate_android.cc View 2 chunks +7 lines, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M components/infobars/core/infobar_delegate.h View 2 chunks +7 lines, -0 lines 0 comments Download
M components/infobars/core/infobar_delegate.cc View 1 chunk +8 lines, -1 line 0 comments Download
M content/browser/media/android/browser_media_player_manager.h View 4 chunks +31 lines, -10 lines 0 comments Download
M content/browser/media/android/browser_media_player_manager.cc View 11 chunks +99 lines, -46 lines 0 comments Download
A content/browser/media/android/media_throttler.h View 1 chunk +45 lines, -0 lines 0 comments Download
A content/browser/media/android/media_throttler.cc View 1 chunk +48 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_message_filter.cc View 3 chunks +26 lines, -8 lines 0 comments Download
M content/content_browser.gypi View 2 chunks +3 lines, -0 lines 0 comments Download
M content/content_jni.gypi View 1 chunk +1 line, -0 lines 0 comments Download
A content/public/android/java/res/raw/empty.wav View Binary file 0 comments Download
A content/public/android/java/src/org/chromium/content/browser/MediaThrottler.java View 1 chunk +204 lines, -0 lines 0 comments Download
M content/public/browser/web_contents_delegate.h View 1 chunk +8 lines, -0 lines 0 comments Download
M content/public/browser/web_contents_delegate.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M media/base/android/java/src/org/chromium/media/MediaPlayerListener.java View 2 chunks +1 line, -4 lines 0 comments Download
M media/base/android/media_codec_decoder_unittest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M media/base/android/media_codec_player.h View 3 chunks +6 lines, -7 lines 0 comments Download
M media/base/android/media_codec_player.cc View 5 chunks +13 lines, -13 lines 0 comments Download
M media/base/android/media_codec_video_decoder.h View 2 chunks +1 line, -5 lines 0 comments Download
M media/base/android/media_codec_video_decoder.cc View 3 chunks +2 lines, -6 lines 0 comments Download
M media/base/android/media_player_android.h View 4 chunks +9 lines, -8 lines 0 comments Download
M media/base/android/media_player_android.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M media/base/android/media_player_bridge.h View 2 chunks +13 lines, -9 lines 0 comments Download
M media/base/android/media_player_bridge.cc View 9 chunks +13 lines, -10 lines 0 comments Download
M media/base/android/media_source_player.h View 1 1 chunk +6 lines, -5 lines 0 comments Download
M media/base/android/media_source_player.cc View 1 4 chunks +4 lines, -4 lines 0 comments Download
M media/base/android/media_source_player_unittest.cc View 9 chunks +2 lines, -22 lines 0 comments Download
M media/base/android/video_decoder_job.h View 1 2 chunks +0 lines, -6 lines 0 comments Download
M media/base/android/video_decoder_job.cc View 1 3 chunks +1 line, -4 lines 0 comments Download
M media/base/android/webaudio_media_codec_bridge.h View 2 chunks +3 lines, -1 line 0 comments Download
M media/base/android/webaudio_media_codec_bridge.cc View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
qinmin
5 years, 2 months ago (2015-10-09 17:13:35 UTC) #2
Message was sent while issue was closed. 
Committed patchset #2 (id:40001) manually as
955ff982a4146c7871bafb289c6be02c57ed059c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698