Update LocationBarView Background

ui/views/background.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_VIEWS_BACKGROUND_H_
 #define UI_VIEWS_BACKGROUND_H_
 
 #include "build/build_config.h"
 
 #if defined(OS_WIN)
@@ skipping 36 matching lines @@
   // Creates a background that fills the canvas in the specified color.
   static Background* CreateSolidBackground(int r, int g, int b) {
     return CreateSolidBackground(SkColorSetRGB(r, g, b));
   }
 
   // Creates a background that fills the canvas in the specified color.
   static Background* CreateSolidBackground(int r, int g, int b, int a) {
     return CreateSolidBackground(SkColorSetARGB(a, r, g, b));
   }
 
+  // Creates a background that paints a rectangle with color |background|. This
+  // will also paint a one pixel border around the rectangle of color |border|,
+  // accounting for the scaling of the canvas. If |round| the rectangle will
+  // have rounded corners.
+  static Background* CreateSolidScaledBackground(SkColor background,

[Peter Kasting, 2015/10/19 21:09:44]

Why put this here?  Are you going to be using it outside the location bar?  If
not, I would define your new background class in the .cc file that uses it.

[Evan Stade, 2015/10/19 23:21:30]

The plan is to use it for chips as well (e.g. ev_bubble_view), but I agree it
could live in c/b/u/v/location_bar/ (probably its own file).

[Peter Kasting, 2015/10/19 23:32:23]

Ah, helpful.  Yeah, I would probably avoid touching ui/ unless you're adding
stuff that will be used outside of chrome/.

I would probably also give thought to a different name here, e.g. something
around "BackgroundWith1PxBorder" or some other phrase that emphasizes the
"background and border" nature of this.

[jonross, 2015/10/20 18:54:54]

Evan was going to use this for the omnibox chips

+                                                 SkColor border,
+                                                 bool round);
+
   // Creates a background that contains a vertical gradient that varies
   // from |color1| to |color2|
   static Background* CreateVerticalGradientBackground(SkColor color1,
                                                       SkColor color2);
 
   // Creates a background that contains a vertical gradient. The gradient can
   // have multiple |colors|. The |pos| array contains the relative positions of
   // each corresponding color. |colors| and |pos| must be the same size. The
   // first element in |pos| must be 0.0 and the last element must be 1.0.
   // |count| contains the number of elements in |colors| and |pos|.
@@ skipping 35 matching lines @@
   // TODO(port): Create portable replacement for HBRUSH.
   mutable HBRUSH native_control_brush_;
 #endif  // defined(OS_WIN)
 
   DISALLOW_COPY_AND_ASSIGN(Background);
 };
 
 }  // namespace views
 
 #endif  // UI_VIEWS_BACKGROUND_H_