Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 139473002: Ignore out even if it's a symlink. (Closed)

Created:
6 years, 11 months ago by mtklein
Modified:
6 years, 11 months ago
Reviewers:
hal.canary
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Ignore out even if it's a symlink. R=halcanary@google.com BUG= Committed: http://code.google.com/p/skia/source/detail?r=13089

Patch Set 1 #

Patch Set 2 : reup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M .gitignore View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
mtklein
6 years, 11 months ago (2014-01-15 14:49:08 UTC) #1
hal.canary
On 2014/01/15 14:49:08, mtklein wrote: I can't see the diff! I assume you did a ...
6 years, 11 months ago (2014-01-15 15:58:34 UTC) #2
mtklein
On 2014/01/15 15:58:34, Hal Canary wrote: > On 2014/01/15 14:49:08, mtklein wrote: > > I ...
6 years, 11 months ago (2014-01-15 16:18:10 UTC) #3
hal.canary
LGTM. I was going to do this a while ago, never got around to it.
6 years, 11 months ago (2014-01-15 16:24:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@google.com/139473002/70001
6 years, 11 months ago (2014-01-15 16:28:57 UTC) #5
commit-bot: I haz the power
6 years, 11 months ago (2014-01-15 16:55:07 UTC) #6
Message was sent while issue was closed. 
Change committed as 13089

Powered by Google App Engine
This is Rietveld 408576698