Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Unified Diff: chrome/browser/ui/autofill/tab_autofill_manager_delegate.cc

Issue 13947035: Fail autocheckout if there is no forms in the page. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: add comments for why we do not do null check for TabAutofillManagerDelegate::dialog_controller_ Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/autofill/browser/autofill_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/autofill/tab_autofill_manager_delegate.cc
diff --git a/chrome/browser/ui/autofill/tab_autofill_manager_delegate.cc b/chrome/browser/ui/autofill/tab_autofill_manager_delegate.cc
index 80d6c1353d72cbc9eb23258f66b054f66d67b0bd..38edf3cb143a38387dc9377849ea8fefceb0e881 100644
--- a/chrome/browser/ui/autofill/tab_autofill_manager_delegate.cc
+++ b/chrome/browser/ui/autofill/tab_autofill_manager_delegate.cc
@@ -98,6 +98,8 @@ void TabAutofillManagerDelegate::SetSyncStateChangedCallback(
}
void TabAutofillManagerDelegate::OnAutocheckoutError() {
+ // |dialog_controller_| is a WeakPtr, but we require it to be present when
+ // |OnAutocheckoutError| is called, so we intentionally do not do NULL check.
dialog_controller_->OnAutocheckoutError();
}
@@ -199,6 +201,8 @@ void TabAutofillManagerDelegate::HideAutofillPopup() {
}
void TabAutofillManagerDelegate::UpdateProgressBar(double value) {
+ // |dialog_controller_| is a WeakPtr, but we require it to be present when
+ // |UpdateProgressBar| is called, so we intentionally do not do NULL check.
dialog_controller_->UpdateProgressBar(value);
}
« no previous file with comments | « no previous file | components/autofill/browser/autofill_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698