chrome/browser/ui/autofill/tab_autofill_manager_delegate.cc - Issue 13947035: Fail autocheckout if there is no forms in the page.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/autofill/tab_autofill_manager_delegate.cc

Issue 13947035: Fail autocheckout if there is no forms in the page. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: move logic to ParseForms Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/autofill/tab_autofill_manager_delegate.cc

diff --git a/chrome/browser/ui/autofill/tab_autofill_manager_delegate.cc b/chrome/browser/ui/autofill/tab_autofill_manager_delegate.cc

index 80d6c1353d72cbc9eb23258f66b054f66d67b0bd..56a79881e0ca6e7b905634a3e26e85e9ea579d2c 100644

--- a/chrome/browser/ui/autofill/tab_autofill_manager_delegate.cc

+++ b/chrome/browser/ui/autofill/tab_autofill_manager_delegate.cc

@@ -98,7 +98,8 @@ void TabAutofillManagerDelegate::SetSyncStateChangedCallback(

}

void TabAutofillManagerDelegate::OnAutocheckoutError() {

- dialog_controller_->OnAutocheckoutError();

+ if (dialog_controller_)

ahutter 2013/04/10 22:38:06 I still don't think this change should be here.

benquan 2013/04/11 02:17:56 replaced the null check with a comment

+ dialog_controller_->OnAutocheckoutError();

}

void TabAutofillManagerDelegate::ShowAutofillSettings() {

« no previous file with comments | « no previous file | components/autofill/browser/autofill_manager.cc » ('j') | no next file with comments »