Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Unified Diff: components/autofill/browser/autofill_manager.cc

Issue 13947035: Fail autocheckout if there is no forms in the page. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/browser/autofill_manager.cc
diff --git a/components/autofill/browser/autofill_manager.cc b/components/autofill/browser/autofill_manager.cc
index c9acb0d03ca3ad1a24628b8314025e8869c8d9d4..2f0dad32dc35384604c2e760988d7cd3a048c9ff 100644
--- a/components/autofill/browser/autofill_manager.cc
+++ b/components/autofill/browser/autofill_manager.cc
@@ -466,6 +466,14 @@ void AutofillManager::OnFormsSeen(const std::vector<FormData>& forms,
}
autocheckout_manager_.OnFormsSeen();
+ if (forms.empty()) {
+ // Call OnLoadedPageMetaData with no page metadata immediately if there is
+ // no form in the page. This give autocheckout_manager a chance to terminate
ahutter 2013/04/10 20:00:59 nit: |autocheckout_manager_|
benquan 2013/04/10 20:12:59 Done.
+ // autocheckout and send autocheckout status.
ahutter 2013/04/10 20:00:59 nit: Autocheckout and either SendAutocheckoutStatu
benquan 2013/04/10 20:12:59 Done.
+ autocheckout_manager_.OnLoadedPageMetaData(
+ scoped_ptr<autofill::AutocheckoutPageMetaData>(NULL));
+ }
+
bool enabled = IsAutofillEnabled();
if (!has_logged_autofill_enabled_) {
metric_logger_->LogIsAutofillEnabledAtPageLoad(enabled);

Powered by Google App Engine
This is Rietveld 408576698