Issue 13947023: Merge 192503 "[Sync] Fix favicon updates to handle orphan nodes"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13947023: Merge 192503 "[Sync] Fix favicon updates to handle orphan nodes" (Closed)

Created:
7 years, 8 months ago by Nicolas Zea

Modified:
7 years, 8 months ago

Reviewers:
Nicolas Zea

CC:
chromium-reviews, Raghu Simha, haitaol1, akalin, tim (not reviewing)

Base URL:
svn://svn.chromium.org/chrome/branches/1453/src/

Visibility:
Public.

Merge 192503 "[Sync] Fix favicon updates to handle orphan nodes" > [Sync] Fix favicon updates to handle orphan nodes > > Image and tracking updates are now tracked separately, so that we properly > distinguish between adds/updates. > > BUG=226539 > > > Review URL: https://chromiumcodereview.appspot.com/13666003 TBR=zea@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193187

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+157 lines, -41 lines)			Patch
M	chrome/browser/sync/glue/favicon_cache.h	View	2 chunks	+5 lines, -10 lines	0 comments	Download
M	chrome/browser/sync/glue/favicon_cache.cc	View	13 chunks	+68 lines, -31 lines	0 comments	Download
M	chrome/browser/sync/glue/favicon_cache_unittest.cc	View	1 chunk	+80 lines, -0 lines	0 comments	Download
M	sync/internal_api/sync_manager_impl.cc	View	2 chunks	+4 lines, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

Message was sent while issue was closed.

Committed patchset #1 manually as r193187.