Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issue 13947023: Merge 192503 "[Sync] Fix favicon updates to handle orphan nodes" (Closed)

Created:
7 years, 8 months ago by Nicolas Zea
Modified:
7 years, 8 months ago
Reviewers:
Nicolas Zea
CC:
chromium-reviews, Raghu Simha, haitaol1, akalin, tim (not reviewing)
Visibility:
Public.

Description

Merge 192503 "[Sync] Fix favicon updates to handle orphan nodes" > [Sync] Fix favicon updates to handle orphan nodes > > Image and tracking updates are now tracked separately, so that we properly > distinguish between adds/updates. > > BUG=226539 > > > Review URL: https://chromiumcodereview.appspot.com/13666003 TBR=zea@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193187

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+157 lines, -41 lines) Patch
M chrome/browser/sync/glue/favicon_cache.h View 2 chunks +5 lines, -10 lines 0 comments Download
M chrome/browser/sync/glue/favicon_cache.cc View 13 chunks +68 lines, -31 lines 0 comments Download
M chrome/browser/sync/glue/favicon_cache_unittest.cc View 1 chunk +80 lines, -0 lines 0 comments Download
M sync/internal_api/sync_manager_impl.cc View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Nicolas Zea
7 years, 8 months ago (2013-04-09 19:57:46 UTC) #1
Nicolas Zea
7 years, 8 months ago (2013-04-09 19:58:02 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r193187.

Powered by Google App Engine
This is Rietveld 408576698