Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Issue 13947002: Update App Launcher icons, splitting for Chromium, Chrome, Canary. (Closed)

Created:
7 years, 8 months ago by tapted
Modified:
7 years, 8 months ago
Reviewers:
benwells, oshima, sky
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina, jeremya+watch_chromium.org, Aaron Boodman, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Update App Launcher icons, splitting for Chromium, Chrome, Canary. More binaries at http://go/chromerev/7719014/ . theme/app_list.ico | Bin 43766 -> 0 bytes theme/chromium/app_list.ico | Bin 0 -> 26489 bytes theme/chromium/app_list_48.png | Bin 0 -> 1142 bytes theme/default_100_percent/win/app_list.png | Bin 1279 -> 0 bytes src-internal binaries: http://go/viewvc/chrome-internal?view=rev&revision=36431 src-internal DEPS roll: http://go/viewvc/chrome-internal?view=rev&revision=36446 BUG=180700 TEST=official Chrome installer built and icons checked with and without --chrome-sxs. App Launcher enabled via chrome://flags to verify icons used in taskbar. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195449

Patch Set 1 : #

Patch Set 2 : selfnits #

Total comments: 7

Patch Set 3 : rebase for r193097 and fix app_list_controller_win.cc conflicts #

Patch Set 4 : move to app_list_service_win.cc #

Total comments: 1

Patch Set 5 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -15 lines) Patch
M apps/app_host/app_host.rc View 1 1 chunk +5 lines, -1 line 0 comments Download
M chrome/app/chrome_exe.rc View 1 2 3 4 1 chunk +9 lines, -3 lines 0 comments Download
D chrome/app/theme/app_list.ico View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/chromium/app_list.ico View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/default_100_percent/chromium/app_list_48.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/app/theme/default_100_percent/win/app_list.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/app/theme/theme_resources.grd View 1 2 3 4 1 chunk +6 lines, -2 lines 0 comments Download
M chrome/browser/ui/app_list/app_list_service_win.h View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
A chrome/browser/ui/app_list/app_list_service_win.cc View 1 2 3 1 chunk +24 lines, -0 lines 0 comments Download
M chrome/browser/ui/extensions/app_metro_infobar_delegate_win.cc View 1 2 3 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/app_list/app_list_controller_win.cc View 1 2 3 4 6 chunks +22 lines, -11 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
tapted
Ben, could you take an initial look? I'll need to wait for your change in ...
7 years, 8 months ago (2013-04-09 11:35:20 UTC) #1
tapted
https://codereview.chromium.org/13947002/diff/6001/apps/app_host/app_host.rc File apps/app_host/app_host.rc (right): https://codereview.chromium.org/13947002/diff/6001/apps/app_host/app_host.rc#newcode34 apps/app_host/app_host.rc:34: IDI_APP_HOST_MAIN ICON "..\\..\\chrome\\app\\theme\\google_chrome\\app_list.ico" Note: The canary icon isn't here. ...
7 years, 8 months ago (2013-04-09 11:38:11 UTC) #2
benwells
https://codereview.chromium.org/13947002/diff/6001/apps/app_host/app_host.rc File apps/app_host/app_host.rc (right): https://codereview.chromium.org/13947002/diff/6001/apps/app_host/app_host.rc#newcode34 apps/app_host/app_host.rc:34: IDI_APP_HOST_MAIN ICON "..\\..\\chrome\\app\\theme\\google_chrome\\app_list.ico" On 2013/04/09 11:38:11, tapted wrote: > ...
7 years, 8 months ago (2013-04-09 22:34:44 UTC) #3
tapted
https://codereview.chromium.org/13947002/diff/6001/chrome/app/chrome_exe.rc File chrome/app/chrome_exe.rc (right): https://codereview.chromium.org/13947002/diff/6001/chrome/app/chrome_exe.rc#newcode55 chrome/app/chrome_exe.rc:55: IDR_X_APP_LIST_SXS ICON "theme\\google_chrome\\app_list_sxs.ico" here's the canary :D -- just ...
7 years, 8 months ago (2013-04-10 06:36:37 UTC) #4
benwells
lgtm
7 years, 8 months ago (2013-04-10 06:50:52 UTC) #5
tapted
Adding for OWNERS, sky - chrome/app/chrome_exe.rc - chrome/chrome_browser_ui.gypi oshima - chrome/app/theme/theme_resources.grd - other binaries under ...
7 years, 8 months ago (2013-04-10 07:33:59 UTC) #6
sky
LGTM
7 years, 8 months ago (2013-04-10 14:45:14 UTC) #7
oshima
chrome/app/theme lgtm
7 years, 8 months ago (2013-04-10 18:17:51 UTC) #8
tapted
All the src-internal changes have landed. This has a binary move, so I will need ...
7 years, 8 months ago (2013-04-22 05:49:48 UTC) #9
tapted
7 years, 8 months ago (2013-04-22 05:51:34 UTC) #10
Message was sent while issue was closed.
Committed patchset #5 manually as r195449 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698