Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Unified Diff: runtime/vm/stack_frame.cc

Issue 1394673002: Move reusable handles from isolate to thread. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Fix release build Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/service.cc ('k') | runtime/vm/thread.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/stack_frame.cc
diff --git a/runtime/vm/stack_frame.cc b/runtime/vm/stack_frame.cc
index 5f86c3bc8fdd009b71366a6131d2771a170152c7..7594b91cd222124e55bfa255753e627eaccf038a 100644
--- a/runtime/vm/stack_frame.cc
+++ b/runtime/vm/stack_frame.cc
@@ -207,8 +207,7 @@ bool StackFrame::FindExceptionHandler(Thread* thread,
uword* handler_pc,
bool* needs_stacktrace,
bool* has_catch_all) const {
- Isolate* isolate = thread->isolate();
- REUSABLE_CODE_HANDLESCOPE(isolate);
+ REUSABLE_CODE_HANDLESCOPE(thread);
Code& code = reused_code_handle.Handle();
code = LookupDartCode();
if (code.IsNull()) {
@@ -216,7 +215,7 @@ bool StackFrame::FindExceptionHandler(Thread* thread,
}
uword pc_offset = pc() - code.EntryPoint();
- REUSABLE_EXCEPTION_HANDLERS_HANDLESCOPE(isolate);
+ REUSABLE_EXCEPTION_HANDLERS_HANDLESCOPE(thread);
ExceptionHandlers& handlers = reused_exception_handlers_handle.Handle();
handlers = code.exception_handlers();
if (handlers.num_entries() == 0) {
@@ -224,7 +223,7 @@ bool StackFrame::FindExceptionHandler(Thread* thread,
}
// Find pc descriptor for the current pc.
- REUSABLE_PC_DESCRIPTORS_HANDLESCOPE(isolate);
+ REUSABLE_PC_DESCRIPTORS_HANDLESCOPE(thread);
PcDescriptors& descriptors = reused_pc_descriptors_handle.Handle();
descriptors = code.pc_descriptors();
PcDescriptors::Iterator iter(descriptors, RawPcDescriptors::kAnyKind);
« no previous file with comments | « runtime/vm/service.cc ('k') | runtime/vm/thread.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698