Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Unified Diff: runtime/vm/profiler.cc

Issue 1394673002: Move reusable handles from isolate to thread. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Fix release build Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/profiler.h ('k') | runtime/vm/reusable_handles.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/profiler.cc
diff --git a/runtime/vm/profiler.cc b/runtime/vm/profiler.cc
index 079b35026cfb23945cbeecc1267a359241001a7d..1515eed45563e78c82a360e9283be5a103d0b259 100644
--- a/runtime/vm/profiler.cc
+++ b/runtime/vm/profiler.cc
@@ -1253,9 +1253,8 @@ ProcessedSample* SampleBuffer::BuildProcessedSample(Sample* sample) {
}
if (!sample->exit_frame_sample()) {
- Isolate* isolate = thread->isolate();
Isolate* vm_isolate = Dart::vm_isolate();
- processed_sample->FixupCaller(isolate,
+ processed_sample->FixupCaller(thread,
vm_isolate,
sample->pc_marker(),
sample->GetStackBuffer());
@@ -1296,14 +1295,14 @@ ProcessedSample::ProcessedSample()
}
-void ProcessedSample::FixupCaller(Isolate* isolate,
+void ProcessedSample::FixupCaller(Thread* thread,
Isolate* vm_isolate,
uword pc_marker,
uword* stack_buffer) {
- REUSABLE_CODE_HANDLESCOPE(isolate);
+ REUSABLE_CODE_HANDLESCOPE(thread);
// Lookup code object for leaf frame.
Code& code = reused_code_handle.Handle();
- code = FindCodeForPC(isolate, vm_isolate, At(0));
+ code = FindCodeForPC(thread->isolate(), vm_isolate, At(0));
if (code.IsNull()) {
return;
}
@@ -1311,7 +1310,8 @@ void ProcessedSample::FixupCaller(Isolate* isolate,
// Code compiled after sample. Ignore.
return;
}
- CheckForMissingDartFrame(isolate, vm_isolate, code, pc_marker, stack_buffer);
+ CheckForMissingDartFrame(
+ thread->isolate(), vm_isolate, code, pc_marker, stack_buffer);
}
« no previous file with comments | « runtime/vm/profiler.h ('k') | runtime/vm/reusable_handles.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698