Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(637)

Unified Diff: runtime/vm/handles.h

Issue 1394673002: Move reusable handles from isolate to thread. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Fix release build Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/gc_marker.cc ('k') | runtime/vm/isolate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/handles.h
diff --git a/runtime/vm/handles.h b/runtime/vm/handles.h
index 343d13908fa81530767f358868ad996c68c5dbe8..c5bcac798a86ac4c1a8a8e71e83b9937db8f67af 100644
--- a/runtime/vm/handles.h
+++ b/runtime/vm/handles.h
@@ -58,21 +58,22 @@ namespace dart {
// Forward declarations.
class ObjectPointerVisitor;
+class Thread;
DECLARE_FLAG(bool, verify_handles);
DECLARE_DEBUG_FLAG(bool, trace_handles);
class HandleVisitor {
public:
- explicit HandleVisitor(Isolate* isolate) : isolate_(isolate) {}
+ explicit HandleVisitor(Thread* thread) : thread_(thread) {}
virtual ~HandleVisitor() {}
- Isolate* isolate() const { return isolate_; }
+ Thread* thread() const { return thread_; }
virtual void VisitHandle(uword addr) = 0;
private:
- Isolate* isolate_;
+ Thread* thread_;
DISALLOW_IMPLICIT_CONSTRUCTORS(HandleVisitor);
};
@@ -238,7 +239,7 @@ class Handles {
friend class HandleScope;
friend class Dart;
friend class ObjectStore;
- friend class Isolate;
+ friend class Thread;
DISALLOW_ALLOCATION();
DISALLOW_COPY_AND_ASSIGN(Handles);
};
« no previous file with comments | « runtime/vm/gc_marker.cc ('k') | runtime/vm/isolate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698