Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Issue 1394663003: Support deeply nested uncommonAttributeSelectors. (Closed)

Created:
5 years, 2 months ago by rune
Modified:
5 years, 2 months ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, chromium-reviews, dglazkov+blink, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Support deeply nested uncommonAttributeSelectors. Selectors containing attribute selectors are collected to the StyleResolver and matched against elements to check if they can share style with other elements. The function looking for attributes only went one level down for functional pseudo classes, which means selectors like: :-webkit-any(:not([attr])) were ignored and caused style to be incorrectly shared between elements. R=leviw@chromium.org BUG=540856 Committed: https://crrev.com/ab771e4962f9ae0eded016f6bf83f6935d98e80e Cr-Commit-Position: refs/heads/master@{#353019}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -5 lines) Patch
A third_party/WebKit/LayoutTests/fast/selectors/style-sharing-attribute-selector.html View 1 chunk +26 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/selectors/style-sharing-attribute-selector-expected.txt View 1 chunk +14 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/RuleSet.cpp View 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
rune
5 years, 2 months ago (2015-10-07 21:46:59 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1394663003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1394663003/1
5 years, 2 months ago (2015-10-07 21:48:02 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-07 23:18:26 UTC) #5
leviw_travelin_and_unemployed
lgtm Good catch!
5 years, 2 months ago (2015-10-08 07:55:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1394663003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1394663003/1
5 years, 2 months ago (2015-10-08 07:56:15 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-08 08:00:20 UTC) #9
commit-bot: I haz the power
5 years, 2 months ago (2015-10-08 08:01:16 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ab771e4962f9ae0eded016f6bf83f6935d98e80e
Cr-Commit-Position: refs/heads/master@{#353019}

Powered by Google App Engine
This is Rietveld 408576698