Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(530)

Issue 139463007: no need to refcnt colortables, since pixelrefs own them (Closed)

Created:
6 years, 11 months ago by reed1
Modified:
6 years, 11 months ago
Reviewers:
hal.canary, scroggo
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

no need to refcnt colortables, since pixelrefs own them BUG=skia: R=halcanary@google.com, scroggo@google.com Committed: https://code.google.com/p/skia/source/detail?r=13098

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -22 lines) Patch
M include/core/SkBitmap.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/core/SkBitmap.cpp View 5 chunks +4 lines, -20 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
reed1
6 years, 11 months ago (2014-01-15 19:28:38 UTC) #1
scroggo
On 2014/01/15 19:28:38, reed1 wrote: lgtm
6 years, 11 months ago (2014-01-15 19:38:25 UTC) #2
hal.canary
LGTM
6 years, 11 months ago (2014-01-15 19:56:51 UTC) #3
reed1
6 years, 11 months ago (2014-01-15 19:59:51 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r13098 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698