Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Issue 139463005: Makes Window::RecreateLayer() reset bounds (Closed)

Created:
6 years, 11 months ago by sky
Modified:
6 years, 11 months ago
Reviewers:
pkotwicz
CC:
chromium-reviews, sadrul, ben+aura_chromium.org, kalyank
Visibility:
Public.

Description

Makes Window::RecreateLayer() reset bounds This gives back original behavior, making Layer and Window reset bounds when RecreateLayer is invoked. BUG=328062 TEST=covered by test now R=pkotwicz@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245179

Patch Set 1 #

Total comments: 2

Patch Set 2 : update comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M ui/aura/window.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/aura/window_unittest.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
sky
6 years, 11 months ago (2014-01-15 16:51:43 UTC) #1
pkotwicz
LGTM with nit Do you have any suggestions as to how to avoid the layout ...
6 years, 11 months ago (2014-01-15 17:10:10 UTC) #2
sky
As to 323791, maybe RecreateLayer() should take a boolean indicating if bounds should persist or ...
6 years, 11 months ago (2014-01-15 17:23:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/139463005/60001
6 years, 11 months ago (2014-01-15 17:41:42 UTC) #4
commit-bot: I haz the power
6 years, 11 months ago (2014-01-16 06:50:33 UTC) #5
Message was sent while issue was closed.
Change committed as 245179

Powered by Google App Engine
This is Rietveld 408576698