Issue 1394613002: Create local copy of Dart assembler code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1394613002: Create local copy of Dart assembler code. (Closed)

Created:
5 years, 2 months ago by Karl

Modified:
5 years, 2 months ago

Reviewers:
Jim Stichnoth, John

CC:
native-client-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Create local copy of Dart assembler code. Creates a local version of the Dart assembler code, before being merged into our code base. The goal of these files is to track code as it is moved from the Dart implementation into our code base. BUG= https://code.google.com/p/nativeclient/issues/detail?id=4334 R=jpp@chromium.org, stichnot@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=3e53dc99c9f61fc1f65e85735220f0b03d2487ca

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4869 lines, -0 lines)			Patch
M	Makefile.standalone	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
A	src/DartARM32/assembler_arm.h	View		1 chunk	+1214 lines, -0 lines	0 comments	Download
A	src/DartARM32/assembler_arm.cc	View		1 chunk	+3653 lines, -0 lines	0 comments	Download

Total messages: 5 (1 generated)

Jim Stichnoth

Also LGTM. Can you add these files to FORMAT_BLACKLIST in Makefile.standalone so that "make format" ...

5 years, 2 months ago (2015-10-07 19:50:01 UTC) #4

Karl

5 years, 2 months ago (2015-10-07 20:24:07 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
3e53dc99c9f61fc1f65e85735220f0b03d2487ca (presubmit successful).