Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(466)

Issue 1394603003: Add dependency on gfx_vector_icons to autofill_core_browser (Closed)

Created:
5 years, 2 months ago by mpawlowski
Modified:
5 years, 2 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add dependency on gfx_vector_icons to autofill_core_browser autofill_cc_infobar_delegate.cc which is built as part of autofill_core_browser uses generated vector_icons.h, there should be an explicit dependency otherwise builds succeed randomly. BUG= Committed: https://crrev.com/f94776e2fcf18c26af89dd4870f7114c8e87538d Cr-Commit-Position: refs/heads/master@{#353305}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M components/autofill.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
mpawlowski
5 years, 2 months ago (2015-10-09 13:10:30 UTC) #2
Evan Stade
lgtm thanks
5 years, 2 months ago (2015-10-09 15:19:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1394603003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1394603003/1
5 years, 2 months ago (2015-10-09 15:21:18 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-09 16:26:09 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-10-09 16:27:08 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f94776e2fcf18c26af89dd4870f7114c8e87538d
Cr-Commit-Position: refs/heads/master@{#353305}

Powered by Google App Engine
This is Rietveld 408576698