FileAPI: Run database recovery on IOError.

webkit/fileapi/file_system_directory_database_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "webkit/fileapi/file_system_directory_database.h"
 
 #include <math.h>
 #include <limits>
 
 #include "base/file_util.h"
@@ skipping 632 matching lines @@
   CorruptDatabase(kDatabaseDirectory, leveldb::kLogFile,
                   -1, 1);
   InitDatabase();
   EXPECT_FALSE(db()->IsFileSystemConsistent());
 
   FileId file_id;
   EXPECT_FALSE(db()->GetChildWithName(0, kFileName, &file_id));
   EXPECT_TRUE(db()->IsFileSystemConsistent());
 }
 
+TEST_F(FileSystemDirectoryDatabaseTest, TestRepairDatabase_MissingManifest) {
+  base::FilePath::StringType kFileName = FPL("bar");
+
+  FileId file_id_prev;
+  CreateFile(0, FPL("foo"), FPL("hoge"), NULL);
+  CreateFile(0, kFileName, FPL("fuga"), &file_id_prev);
+
+  const base::FilePath kDatabaseDirectory =
+      path().Append(kDirectoryDatabaseName);
+  CloseDatabase();
+
+  DeleteDatabaseFile(kDatabaseDirectory, leveldb::kDescriptorFile);

[kinuko, 2013/04/10 06:23:49]

What happens when other files are deleted?

[tzik, 2013/04/10 06:49:20]

For .sst deletion, that was handled as corruption.
Other file deletion for LOG, LOG.old, CURRENT, LOCK, lost/*  or *.log caused no
error.
MANIFEST-* file deletion seems only case that we didn't handled.

[kinuko, 2013/04/10 08:41:17]

Should we add tests for them too (even if they may not be handled by the new
code)?

[tzik, 2013/04/10 10:59:49]

Added tests for them on OriginDatabase test.
Should we also add for DirectoryDatabase?

[kinuko, 2013/04/10 11:02:13]

If you think we should do so please add them; I'm fine with this (if anything
changes in leveldb the other test will catch).

[tzik, 2013/04/10 13:01:09]

I believe it's enough to catch leveldb change. ;)

+
+  InitDatabase();
+  EXPECT_FALSE(db()->IsFileSystemConsistent());
+
+  FileId file_id;
+  EXPECT_TRUE(db()->GetChildWithName(0, kFileName, &file_id));
+  EXPECT_EQ(file_id_prev, file_id);
+
+  EXPECT_TRUE(db()->IsFileSystemConsistent());
+}
+
 }  // namespace fileapi