Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1394573003: chromeos: Add SurfaceServiceProvider. (Closed)

Created:
5 years, 2 months ago by reveman
Modified:
5 years, 1 month ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

chromeos: Add SurfaceServiceProvider. BUG=

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+791 lines, -0 lines) Patch
M ash/accelerators/accelerator_controller.cc View 1 4 chunks +21 lines, -0 lines 0 comments Download
M ash/accelerators/accelerator_table.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M ash/accelerators/accelerator_table.cc View 1 2 chunks +6 lines, -0 lines 0 comments Download
M ash/ash.gyp View 1 2 chunks +5 lines, -0 lines 0 comments Download
M ash/shell.h View 3 chunks +5 lines, -0 lines 0 comments Download
M ash/shell.cc View 1 3 chunks +4 lines, -0 lines 0 comments Download
A + ash/surfaces/DEPS View 1 1 chunk +1 line, -0 lines 0 comments Download
A ash/surfaces/surface_controller.h View 1 1 chunk +69 lines, -0 lines 0 comments Download
A ash/surfaces/surface_controller.cc View 1 2 3 1 chunk +159 lines, -0 lines 0 comments Download
A ash/surfaces/test_shell_surface_overlay_view.h View 1 2 1 chunk +45 lines, -0 lines 0 comments Download
A ash/surfaces/test_shell_surface_overlay_view.cc View 1 2 1 chunk +116 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/chrome_browser_main_chromeos.cc View 1 3 chunks +4 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/dbus/chrome_surface_service_provider_delegate.h View 1 1 chunk +40 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/dbus/chrome_surface_service_provider_delegate.cc View 1 1 chunk +91 lines, -0 lines 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M chromeos/chromeos.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
A chromeos/dbus/services/surface_service_provider.h View 1 1 chunk +74 lines, -0 lines 1 comment Download
A chromeos/dbus/services/surface_service_provider.cc View 1 1 chunk +135 lines, -0 lines 0 comments Download
M tools/metrics/actions/actions.xml View 1 2 chunks +10 lines, -0 lines 0 comments Download

Depends on Patchset:

Issue 1401063002 Patch 1

Messages

Total messages: 4 (2 generated)
denniskempin (chromium)
https://codereview.chromium.org/1394573003/diff/1/ash/surfaces/test_surface_overlay_view.h File ash/surfaces/test_surface_overlay_view.h (right): https://codereview.chromium.org/1394573003/diff/1/ash/surfaces/test_surface_overlay_view.h#newcode27 ash/surfaces/test_surface_overlay_view.h:27: class TestSurfaceOverlayView : public views::WidgetDelegateView, I know this code ...
5 years, 2 months ago (2015-10-09 21:16:25 UTC) #2
Junichi Uekawa
5 years, 2 months ago (2015-10-20 04:11:33 UTC) #4 
https://codereview.chromium.org/1394573003/diff/60001/chromeos/dbus/services/...
File chromeos/dbus/services/surface_service_provider.h (right):

https://codereview.chromium.org/1394573003/diff/60001/chromeos/dbus/services/...
chromeos/dbus/services/surface_service_provider.h:39: const base::Closure&
released_callback);
This is not defined anywhere, and should marked as a pure virtual function or
Debug build will not build.


just add =0 as above.

Powered by Google App Engine
This is Rietveld 408576698