presubmit_canned_checks.py - Issue 1394563003: Add long line exception for GEN('#include') in JS browser tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: presubmit_canned_checks.py

Issue 1394563003: Add long line exception for GEN('#include') in JS browser tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master

Patch Set: #thankspython Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: presubmit_canned_checks.py

diff --git a/presubmit_canned_checks.py b/presubmit_canned_checks.py

index 5ed86568fffec4c766f90d8de396673e2ea6fda7..61d231859c51270c2bb81cfc4347948940fdf103 100644

--- a/presubmit_canned_checks.py

+++ b/presubmit_canned_checks.py

@@ -342,15 +342,18 @@ def CheckLongLines(input_api, output_api, maxlen, source_file_filter=None):

CPP_EXCEPTIONS = ('#define', '#endif', '#if', '#include', '#pragma')

JAVA_FILE_EXTS = ('java',)

JAVA_EXCEPTIONS = ('import ', 'package ')

+ JS_FILE_EXTS = ('js',)

+ JS_EXCEPTIONS = ("GEN('#include")

M-A Ruel 2015/10/08 17:39:29 need one there too

Dan Beam 2015/10/08 17:48:06 Done. (also grepped the file for ('[^']+') -- didn

OBJC_FILE_EXTS = ('h', 'm', 'mm')

OBJC_EXCEPTIONS = ('#define', '#endif', '#if', '#import', '#include',

'#pragma')

- PY_FILE_EXTS = ('py')

+ PY_FILE_EXTS = ('py',)

PY_EXCEPTIONS = ('import', 'from')

LANGUAGE_EXCEPTIONS = [

(CPP_FILE_EXTS, CPP_EXCEPTIONS),

(JAVA_FILE_EXTS, JAVA_EXCEPTIONS),

+ (JS_FILE_EXTS, JS_EXCEPTIONS),

(OBJC_FILE_EXTS, OBJC_EXCEPTIONS),

(PY_FILE_EXTS, PY_EXCEPTIONS),

]

« no previous file with comments | « no previous file | tests/presubmit_unittest.py » ('j') | no next file with comments »