Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Unified Diff: storage/browser/quota/quota_manager.cc

Issue 1394563002: Add trace to the caller of QuotaManager::GetAvailableSpace (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: storage/browser/quota/quota_manager.cc
diff --git a/storage/browser/quota/quota_manager.cc b/storage/browser/quota/quota_manager.cc
index 52f728086b7169b02f5b62831cf50f7108b6c619..8c0073c54aea62db1b2654828c17d9f17a9a61c0 100644
--- a/storage/browser/quota/quota_manager.cc
+++ b/storage/browser/quota/quota_manager.cc
@@ -19,6 +19,7 @@
#include "base/sys_info.h"
#include "base/task_runner_util.h"
#include "base/time/time.h"
+#include "base/trace_event/trace_event.h"
#include "net/base/net_util.h"
#include "storage/browser/quota/client_usage_tracker.h"
#include "storage/browser/quota/quota_manager_proxy.h"
@@ -188,6 +189,9 @@ bool UpdateModifiedTimeOnDBThread(const GURL& origin,
}
int64 CallSystemGetAmountOfFreeDiskSpace(const base::FilePath& profile_path) {
+ // crbug.com/349708
+ TRACE_EVENT0("io", "QuotaManager::GetUsageAndQuotaForEviction");
michaeln 2015/10/09 22:10:39 the label s/b "CallSystemGetAmountOfFreeDiskSpace"
oshima 2015/10/09 22:36:48 Done.
+
// Ensure the profile path exists.
if (!base::CreateDirectory(profile_path)) {
LOG(WARNING) << "Create directory failed for path" << profile_path.value();
@@ -410,6 +414,10 @@ class UsageAndQuotaCallbackDispatcher
}
void DidGetAvailableSpace(QuotaStatusCode status, int64 space) {
+ // crbug.com/349708
+ TRACE_EVENT0(
+ "io", "UsageAndQuotaCallbackDispatcher::DidGetAvailableSpace");
+
DCHECK_GE(space, 0);
if (status_ == kQuotaStatusUnknown || status_ == kQuotaStatusOk)
status_ = status;
@@ -430,6 +438,9 @@ class UsageAndQuotaCallbackDispatcher
}
void Completed() override {
+ // crbug.com/349708
+ TRACE_EVENT0("io", "UsageAndQuotaCallbackDispatcher::Completed");
+
DCHECK(!has_usage_ || usage_and_quota_.usage >= 0);
DCHECK(!has_global_limited_usage_ ||
usage_and_quota_.global_limited_usage >= 0);
@@ -472,6 +483,9 @@ class QuotaManager::GetUsageInfoTask : public QuotaTask {
protected:
void Run() override {
+ // crbug.com/349708
+ TRACE_EVENT0("io", "QuotaManager::GetUsageInfoTask::Completed");
michaeln 2015/10/09 22:10:39 label should say "::Run"
oshima 2015/10/09 22:36:48 Done.
+
remaining_trackers_ = 3;
// This will populate cached hosts and usage info.
manager()->GetUsageTracker(kStorageTypeTemporary)->GetGlobalUsage(
@@ -489,6 +503,9 @@ class QuotaManager::GetUsageInfoTask : public QuotaTask {
}
void Completed() override {
+ // crbug.com/349708
+ TRACE_EVENT0("io", "QuotaManager::GetUsageInfoTask::Completed");
+
callback_.Run(entries_);
DeleteSoon();
}
@@ -566,11 +583,17 @@ class QuotaManager::OriginDataDeleter : public QuotaTask {
void Completed() override {
if (error_count_ == 0) {
+ // crbug.com/349708
+ TRACE_EVENT0("io", "QuotaManager::OriginDataDeleter::Completed Ok");
+
// Only remove the entire origin if we didn't skip any client types.
if (skipped_clients_ == 0)
manager()->DeleteOriginFromDatabase(origin_, type_);
callback_.Run(kQuotaStatusOk);
} else {
+ // crbug.com/349708
+ TRACE_EVENT0("io", "QuotaManager::OriginDataDeleter::Completed Error");
+
callback_.Run(kQuotaErrorInvalidModification);
}
DeleteSoon();
@@ -640,8 +663,14 @@ class QuotaManager::HostDataDeleter : public QuotaTask {
void Completed() override {
if (error_count_ == 0) {
+ // crbug.com/349708
+ TRACE_EVENT0("io", "QuotaManager::HostDataDeleter::Completed Ok");
+
callback_.Run(kQuotaStatusOk);
} else {
+ // crbug.com/349708
+ TRACE_EVENT0("io", "QuotaManager::HostDataDeleter::Completed Error");
+
callback_.Run(kQuotaErrorInvalidModification);
}
DeleteSoon();
@@ -960,6 +989,8 @@ void QuotaManager::DeleteHostData(const std::string& host,
void QuotaManager::GetAvailableSpace(const AvailableSpaceCallback& callback) {
if (!available_space_callbacks_.Add(callback))
return;
+ // crbug.com/349708
+ TRACE_EVENT0("io", "QuotaManager::GetAvailableSpace");
PostTaskAndReplyWithResult(db_thread_.get(),
FROM_HERE,
@@ -1462,6 +1493,9 @@ void QuotaManager::EvictOriginData(const GURL& origin,
void QuotaManager::GetUsageAndQuotaForEviction(
const UsageAndQuotaCallback& callback) {
+ // crbug.com/349708
+ TRACE_EVENT0("io", "QuotaManager::GetUsageAndQuotaForEviction");
+
DCHECK(io_thread_->BelongsToCurrentThread());
LazyInitialize();
@@ -1602,6 +1636,10 @@ void QuotaManager::DidInitializeTemporaryOriginsInfo(bool success) {
}
void QuotaManager::DidGetAvailableSpace(int64 space) {
+ // crbug.com/349708
+ TRACE_EVENT1("io", "QuotaManager::DidGetAvailableSpace",
+ "n_callbacks", available_space_callbacks_.size());
+
available_space_callbacks_.Run(kQuotaStatusOk, space);
}

Powered by Google App Engine
This is Rietveld 408576698