Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2169)

Unified Diff: gpu/command_buffer/common/gles2_cmd_format.h

Issue 1394543003: Added SyncToken command buffer trait to help with IPC messages. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gpu/command_buffer/common/gles2_cmd_format.h
diff --git a/gpu/command_buffer/common/gles2_cmd_format.h b/gpu/command_buffer/common/gles2_cmd_format.h
index 09b87a9a9fce6b6ec581ac875f01f0618f312e7d..05d1d4813da8d35b9a50612c51fe87333313210b 100644
--- a/gpu/command_buffer/common/gles2_cmd_format.h
+++ b/gpu/command_buffer/common/gles2_cmd_format.h
@@ -203,23 +203,6 @@ struct UniformsES3Header {
// UniformES3Info uniforms[num_uniforms];
};
-// The format of fence sync tokens.
-struct SyncToken {
- CommandBufferNamespace namespace_id;
- uint64_t command_buffer_id;
- uint64_t release_count;
-
- bool operator<(const SyncToken& other) const {
- // TODO(dyen): Once all our compilers support c++11, we can replace this
- // long list of comparisons with std::tie().
- return (namespace_id < other.namespace_id) ||
- ((namespace_id == other.namespace_id) &&
- ((command_buffer_id < other.command_buffer_id) ||
- ((command_buffer_id == other.command_buffer_id) &&
- (release_count < other.release_count))));
- }
-};
-
// The format of QuerySync used by EXT_occlusion_query_boolean
struct QuerySync {
void Reset() {
@@ -314,9 +297,6 @@ static_assert(sizeof(UniformBlocksHeader) == 4,
static_assert(offsetof(UniformBlocksHeader, num_uniform_blocks) == 0,
"offset of UniformBlocksHeader.num_uniform_blocks should be 0");
-static_assert(sizeof(SyncToken) <= GL_SYNC_TOKEN_SIZE_CHROMIUM,
- "size of SyncToken must not exceed GL_SYNC_TOKEN_SIZE_CHROMIUM");
-
namespace cmds {
#include "../common/gles2_cmd_format_autogen.h"

Powered by Google App Engine
This is Rietveld 408576698