Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 13945023: Make URLDataSource::GetSource() const. (Closed)

Created:
7 years, 8 months ago by Jered
Modified:
7 years, 8 months ago
Reviewers:
jam, sky
CC:
chromium-reviews, dbeam+watch-options_chromium.org, nkostylev+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, gideonwald, stevenjb+watch_chromium.org, joi+watch-content_chromium.org, melevin, vsevik, jam, dominich, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, pedrosimonetti+watch_chromium.org, dbeam+watch-ntp_chromium.org, oshima+watch_chromium.org, kmadhusu+watch_chromium.org, sreeram, yurys, Aaron Boodman, David Black, samarth+watch_chromium.org, estade+watch_chromium.org, pfeldman
Visibility:
Public.

Description

Make URLDataSource::GetSource() const. The method is logically const, all callers are already const, and I wanted to call this from a const method. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194605

Patch Set 1 #

Patch Set 2 : Fixing another call, TBR. #

Patch Set 3 : And another one. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -49 lines) Patch
M chrome/browser/printing/cloud_print/cloud_print_setup_source.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/printing/cloud_print/cloud_print_setup_source.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/search/local_ntp_source.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/search/local_ntp_source.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/search/local_omnibox_popup_source.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/search/local_omnibox_popup_source.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/about_ui.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/about_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/app_launcher_page_ui.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/app_launcher_page_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/bookmarks_ui.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/bookmarks_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/mobile_setup_ui.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/proxy_settings_ui.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/sim_unlock_ui.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/system_info_ui.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/devtools_ui.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/extensions/extension_icon_source.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/extensions/extension_icon_source.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/favicon_source.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/favicon_source.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/fileicon_source.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/fileicon_source.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/ntp/new_tab_ui.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/ntp/new_tab_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/ntp/thumbnail_source.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/ntp/thumbnail_source.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/chromeos/user_image_source.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/chromeos/user_image_source.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/options_ui.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/screenshot_source.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/screenshot_source.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/session_favicon_source.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/session_favicon_source.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/theme_source.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/theme_source.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/web_ui_browsertest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/browser/webui/shared_resources_data_source.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/webui/shared_resources_data_source.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/webui/web_ui_data_source_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/webui/web_ui_data_source_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/public/browser/url_data_source.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Jered
7 years, 8 months ago (2013-04-16 18:50:24 UTC) #1
Jered
sky, can you take a look at this const cleanup which touches a lot of ...
7 years, 8 months ago (2013-04-16 18:51:01 UTC) #2
sky
I recommend getting an owner of content/public/browser and then TBRing the bulk of this. If ...
7 years, 8 months ago (2013-04-16 19:43:50 UTC) #3
Jered
I realized +jam should be on this since const is an api change technically.
7 years, 8 months ago (2013-04-17 00:21:18 UTC) #4
Jered
On 2013/04/16 19:43:50, sky wrote: > I recommend getting an owner of content/public/browser and then ...
7 years, 8 months ago (2013-04-17 00:22:15 UTC) #5
jam
lgtm
7 years, 8 months ago (2013-04-17 00:48:30 UTC) #6
Jered
7 years, 8 months ago (2013-04-17 16:15:46 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 manually as r194605 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698