Implement missing SysInfo methods on OpenBSD

base/sys_info_linux.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/sys_info.h"
 
 #include <limits>
 
 #include "base/file_util.h"
 #include "base/logging.h"
 #include "base/strings/string_number_conversions.h"
 
-namespace base {
+namespace {
 
-int64 SysInfo::AmountOfPhysicalMemory() {
-  long pages = sysconf(_SC_PHYS_PAGES);
-  long page_size = sysconf(_SC_PAGE_SIZE);
+int64 AmountOfMemory(int pages_name) {
+  long pages = sysconf(pages_name);
+  long page_size = sysconf(_SC_PAGESIZE);

[mdempsky_google, 2013/04/09 21:45:09]

I intentionally changed this from _SC_PAGE_SIZE to _SC_PAGESIZE.  _SC_PAGESIZE
is the standardized name used by POSIX, and _SC_PAGE_SIZE is merely an alias for
it in glibc.  (Curiously, they're distinct #defines in bionic, but bionic's
sysconf() returns the same value for both of them.)

   if (pages == -1 || page_size == -1) {
     NOTREACHED();
     return 0;
   }
+  return static_cast<int64>(pages) * page_size;
+}
 
-  return static_cast<int64>(pages) * page_size;
+}  // namespace
+
+namespace base {
+
+// static
+int64 SysInfo::AmountOfPhysicalMemory() {
+  return AmountOfMemory(_SC_PHYS_PAGES);
 }
 
 // static
 int64 SysInfo::AmountOfAvailablePhysicalMemory() {
-  long available_pages = sysconf(_SC_AVPHYS_PAGES);
-  long page_size = sysconf(_SC_PAGE_SIZE);
-  if (available_pages == -1 || page_size == -1) {
-    NOTREACHED();
-    return 0;
-  }
-  return static_cast<int64>(available_pages) * page_size;
+  return AmountOfMemory(_SC_AVPHYS_PAGES);
 }
 
 // static
 size_t SysInfo::MaxSharedMemorySize() {
   static int64 limit;
   static bool limit_valid = false;
   if (!limit_valid) {
     std::string contents;
     file_util::ReadFileToString(FilePath("/proc/sys/kernel/shmmax"), &contents);
     DCHECK(!contents.empty());
@@ skipping 25 matching lines @@
       if (line.compare(0, strlen(kModelNamePrefix), kModelNamePrefix) == 0) {
         size_t pos = line.find(": ");
         return line.substr(pos + 2);
       }
     }
   }
   return std::string();
 }
 
 }  // namespace base