tools/dom/src/WrappedList.dart - Issue 13945009: Make default argument to Iterable.join be "".

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/dom/src/WrappedList.dart

Issue 13945009: Make default argument to Iterable.join be "". (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Address comments. Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/dom/src/WrappedList.dart

diff --git a/tools/dom/src/WrappedList.dart b/tools/dom/src/WrappedList.dart

index 2e2413d9487164ea27438475d8526e392b62b0fd..b49e307cf069e381ea1c746a06f0cb6c2d4d76b5 100644

--- a/tools/dom/src/WrappedList.dart

+++ b/tools/dom/src/WrappedList.dart

@@ -35,7 +35,7 @@ class _WrappedList<E> implements List<E> {

bool every(bool f(E element)) => _list.every(f);

- String join([String separator]) => _list.join(separator);

+ String join([String separator = ""]) => _list.join(separator);

bool any(bool f(E element)) => _list.any(f);