sdk/lib/core/iterable.dart - Issue 13945009: Make default argument to Iterable.join be "".

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/core/iterable.dart

Issue 13945009: Make default argument to Iterable.join be "". (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Address comments. Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sdk/lib/core/iterable.dart

diff --git a/sdk/lib/core/iterable.dart b/sdk/lib/core/iterable.dart

index 0fda6f168210abd481b330fcab6e19f422e91fc1..dceed11be1502dd50354a70b2bd539b99d97c091 100644

--- a/sdk/lib/core/iterable.dart

+++ b/sdk/lib/core/iterable.dart

@@ -146,9 +146,9 @@ abstract class Iterable<E> {

* Then concatenates the strings, optionally separated by the [separator]

* string.

- String join([String separator]) {

+ String join([String separator = ""]) {

StringBuffer buffer = new StringBuffer();

- buffer.writeAll(this, separator == null ? "" : separator);

+ buffer.writeAll(this, separator);

return buffer.toString();

}

« no previous file with comments | « sdk/lib/collection/list.dart ('k') | sdk/lib/core/string_buffer.dart » ('j') | no next file with comments »