sdk/lib/_internal/compiler/implementation/code_buffer.dart - Issue 13945009: Make default argument to Iterable.join be "".

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/code_buffer.dart

Issue 13945009: Make default argument to Iterable.join be "". (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Address comments. Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sdk/lib/_internal/compiler/implementation/code_buffer.dart

diff --git a/sdk/lib/_internal/compiler/implementation/code_buffer.dart b/sdk/lib/_internal/compiler/implementation/code_buffer.dart

index 4c0a1fe18c0efddc2b4039cd84a54190af215804..1d58b9b6c3b7bce37dc6c8cf7e23e36192eaab57 100644

--- a/sdk/lib/_internal/compiler/implementation/code_buffer.dart

+++ b/sdk/lib/_internal/compiler/implementation/code_buffer.dart

@@ -40,7 +40,7 @@ class CodeBuffer implements StringBuffer {

CodeBuffer writeAll(Iterable<Object> objects, [String separator = ""]) {

Iterator iterator = objects.iterator;

if (!iterator.moveNext()) return this;

- if (separator == "") {

+ if (separator.isEmpty) {

do {

write(iterator.current);

} while (iterator.moveNext());