Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1138)

Unified Diff: sdk/lib/collection/list.dart

Issue 13945009: Make default argument to Iterable.join be "". (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Rebuild dom libraries. Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/_internal/compiler/implementation/lib/js_array.dart ('k') | sdk/lib/core/iterable.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/collection/list.dart
diff --git a/sdk/lib/collection/list.dart b/sdk/lib/collection/list.dart
index 8c9dcd086dde71344cc7b55f95ec5f2ba805883e..a99cf1112642113e5b2ef6e4bd009245128a8913 100644
--- a/sdk/lib/collection/list.dart
+++ b/sdk/lib/collection/list.dart
@@ -181,9 +181,9 @@ abstract class ListMixin<E> implements List<E> {
return max;
}
- String join([String separator]) {
+ String join([String separator = ""]) {
int length = this.length;
- if (separator != null && !separator.isEmpty) {
+ if (separator != "") {
sra1 2013/04/10 09:03:22 ['x','y'].join(null) -> "xnully" is this intent
floitsch 2013/04/10 09:20:37 Changed. Now it's using "isEmpty" again. You still
if (length == 0) return "";
String first = "${this[0]}";
if (length != this.length) {
« no previous file with comments | « sdk/lib/_internal/compiler/implementation/lib/js_array.dart ('k') | sdk/lib/core/iterable.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698