Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Unified Diff: sdk/lib/_internal/compiler/implementation/compiler.dart

Issue 13945008: Move the dart2js snapshot into bin directory of sdk root. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/compiler/implementation/compiler.dart
===================================================================
--- sdk/lib/_internal/compiler/implementation/compiler.dart (revision 21179)
+++ sdk/lib/_internal/compiler/implementation/compiler.dart (working copy)
@@ -16,16 +16,6 @@
const bool DUMP_INFERRED_TYPES = false;
/**
- * A string to identify the revision or build.
- *
- * This ID is displayed if the compiler crashes and in verbose mode, and is
- * an aid in reproducing bug reports.
- *
- * The actual string is rewritten during the SDK build process.
- */
-const String BUILD_ID = 'build number could not be determined';
-
-/**
* Contains backend-specific data that is used throughout the compilation of
* one work item.
*/
@@ -373,6 +363,7 @@
EnqueueTask enqueuer;
CompilerTask fileReadingTask;
DeferredLoadTask deferredLoadTask;
+ String buildId;
static const SourceString MAIN = const SourceString('main');
static const SourceString CALL_OPERATOR_NAME = const SourceString('call');
@@ -418,6 +409,7 @@
bool checkDeprecationInSdk: false,
bool preserveComments: false,
bool verbose: false,
+ String buildId: "build number could not be determined",
ahe 2013/04/10 14:50:08 Could this be this.buildId?
ricow1 2013/04/11 05:45:12 This is a named optional parameter, like the rest
ahe 2013/04/11 06:03:46 I'm not sure you understood my question. I checked
outputProvider,
List<String> strips: const []})
: tracer = tracer,
@@ -432,6 +424,7 @@
checkDeprecationInSdk = checkDeprecationInSdk,
preserveComments = preserveComments,
verbose = verbose,
+ buildId = buildId,
ahe 2013/04/10 14:50:08 this.buildId
ricow1 2013/04/11 05:45:12 again, I just followed the existing convention, bu
ahe 2013/04/11 06:03:46 I need to check the history of these assignments,
libraries = new Map<String, LibraryElement>(),
progress = new Stopwatch(),
this.analyzeOnly = analyzeOnly || analyzeSignaturesOnly,
@@ -517,7 +510,7 @@
}
void pleaseReportCrash() {
- print(MessageKind.PLEASE_REPORT_THE_CRASH.message({'buildId': BUILD_ID}));
+ print(MessageKind.PLEASE_REPORT_THE_CRASH.message({'buildId': buildId}));
}
void cancel(String reason, {Node node, Token token,
@@ -724,15 +717,15 @@
scanBuiltinLibraries();
if (librariesToAnalyzeWhenRun != null) {
for (Uri libraryUri in librariesToAnalyzeWhenRun) {
- log('analyzing $libraryUri ($BUILD_ID)');
+ log('analyzing $libraryUri ($buildId)');
libraryLoader.loadLibrary(libraryUri, null, libraryUri);
}
}
if (uri != null) {
if (analyzeOnly) {
- log('analyzing $uri ($BUILD_ID)');
+ log('analyzing $uri ($buildId)');
} else {
- log('compiling $uri ($BUILD_ID)');
+ log('compiling $uri ($buildId)');
}
mainApp = libraryLoader.loadLibrary(uri, null, uri);
}

Powered by Google App Engine
This is Rietveld 408576698