Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(882)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: test/cctest/test-api.cc

Issue 1394463003: [es6] refactor Promise resolution (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: TODO nit Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/js/promise.js ('k') | test/mjsunit/es6/promises.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-api.cc
diff --git a/test/cctest/test-api.cc b/test/cctest/test-api.cc
index f47c997f518462433d693c9ec5904ae3e702022d..bc6b6aae7b2f5156f4e9a112d101449255a081f8 100644
--- a/test/cctest/test-api.cc
+++ b/test/cctest/test-api.cc
@@ -20308,13 +20308,13 @@ TEST(PromiseThen) {
Handle<Function> f1 = Handle<Function>::Cast(global->Get(v8_str("f1")));
Handle<Function> f2 = Handle<Function>::Cast(global->Get(v8_str("f2")));
- // Chain
- q->Chain(f1);
- CHECK(global->Get(v8_str("x1"))->IsNumber());
+ // TODO(caitp): remove tests once PromiseChain is removed, per bug 3237
+ /* q->Chain(f1);
+ CHECK(global->Get(v8_str2("x1"))->IsNumber());
CHECK_EQ(0, global->Get(v8_str("x1"))->Int32Value());
isolate->RunMicrotasks();
CHECK(!global->Get(v8_str("x1"))->IsNumber());
- CHECK(p->Equals(global->Get(v8_str("x1"))));
+ CHECK(p->Equals(global->Get(v8_str("x1")))); */
// Then
CompileRun("x1 = x2 = 0;");
« no previous file with comments | « src/js/promise.js ('k') | test/mjsunit/es6/promises.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698