test/cctest/test-api.cc - Issue 1394463003: [es6] refactor Promise resolution

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/test-api.cc

Issue 1394463003: [es6] refactor Promise resolution (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: add bug reference to the TODOs Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: test/cctest/test-api.cc

diff --git a/test/cctest/test-api.cc b/test/cctest/test-api.cc

index f47c997f518462433d693c9ec5904ae3e702022d..4c8768373ea9abb72f33cfa5fe1f3c7c92386a3a 100644

--- a/test/cctest/test-api.cc

+++ b/test/cctest/test-api.cc

@@ -20308,13 +20308,13 @@ TEST(PromiseThen) {

Handle<Function> f1 = Handle<Function>::Cast(global->Get(v8_str("f1")));

Handle<Function> f2 = Handle<Function>::Cast(global->Get(v8_str("f2")));

- // Chain

- q->Chain(f1);

- CHECK(global->Get(v8_str("x1"))->IsNumber());

+ // Chain --- DISABLED

Dan Ehrenberg 2015/11/12 22:08:19 TODO?

caitp (gmail) 2015/11/13 22:00:31 Acknowledged.

+ /* q->Chain(f1);

+ CHECK(global->Get(v8_str2("x1"))->IsNumber());

CHECK_EQ(0, global->Get(v8_str("x1"))->Int32Value());

isolate->RunMicrotasks();

CHECK(!global->Get(v8_str("x1"))->IsNumber());

- CHECK(p->Equals(global->Get(v8_str("x1"))));

+ CHECK(p->Equals(global->Get(v8_str("x1")))); */

// Then

CompileRun("x1 = x2 = 0;");

« no previous file with comments | « src/js/promise.js ('k') | test/mjsunit/es6/promises.js » ('j') | no next file with comments »