Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 1394433005: Revert of Supply separate flags for onBuildTileIndex (Closed)

Created:
5 years, 2 months ago by msarett
Modified:
5 years, 2 months ago
Reviewers:
scroggo
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Supply separate flags for onBuildTileIndex (patchset #1 id:1 of https://codereview.chromium.org/1402783008/ ) Reason for revert: Missing an important line. Original issue's description: > Supply separate flags for onBuildTileIndex > > This is a follow up to: > https://codereview.chromium.org/1401283003/ > > Supply separate flags for onBuildTileIndex > > Since png and jpeg's implementations of onBuildTileIndex rely on > modifications to their underlying libraries, rather than whether we are > running on Android, use separate flags that can be disabled > independently. > > This will allow us to easily turn off the feature. It also is a step > towards building and running on other platforms for testing (e.g. > valgrind/ASAN to find memory leaks etc). > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/fc06e9c0e621744654e231ae6fa4460d88c0e27e TBR=scroggo@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/67e676087cb847d40709ef639b2e2ecc7c99bbb2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M src/images/SkJpegUtility.cpp View 5 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
msarett
Created Revert of Supply separate flags for onBuildTileIndex
5 years, 2 months ago (2015-10-14 22:21:00 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1394433005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1394433005/1
5 years, 2 months ago (2015-10-14 22:21:09 UTC) #2
commit-bot: I haz the power
5 years, 2 months ago (2015-10-14 22:21:14 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/67e676087cb847d40709ef639b2e2ecc7c99bbb2

Powered by Google App Engine
This is Rietveld 408576698